Skip to content

Conversation

@rmloveland
Copy link
Contributor

Fixes DOC-8286

@netlify
Copy link

netlify bot commented Nov 10, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit e0cc2b3
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6914feac9c75410008d47f28

@netlify
Copy link

netlify bot commented Nov 10, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit e0cc2b3
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6914feaca6484f00088df69a

@rmloveland rmloveland requested a review from jbowens November 10, 2025 18:42
@rmloveland
Copy link
Contributor Author

@jbowens adding you to review since this was discussed by you and Nick T here, hope that's ok. The doc issue has a linked ZD so at least one customer has hit this

hopefully quick review, just a couple paragraphs and bullets adding the disk slowness detected log message which unfortunately was not searchable in our docs until now 🤦

cc @dshjoshi FYI updating these docs

@netlify
Copy link

netlify bot commented Nov 10, 2025

Netlify Preview

Name Link
🔨 Latest commit e0cc2b3
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6914feacd3c55600089d9eef
😎 Deploy Preview https://deploy-preview-21070--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peachdawnleach peachdawnleach self-requested a review November 10, 2025 21:20
@rmloveland
Copy link
Contributor Author

TFTR @jbowens ! I am planning to backport this change to the docs for everything v24.1 and later, is there any reason why this information would be any different for those prior versions? Sorry, meant to ask in my earlier msg and forgot

Copy link
Contributor

@peachdawnleach peachdawnleach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rmloveland
Copy link
Contributor Author

thanks for the reviews! backporting this change to all supported versions v24.1+

@rmloveland rmloveland enabled auto-merge (squash) November 12, 2025 21:40
@rmloveland rmloveland merged commit 66da887 into main Nov 12, 2025
6 checks passed
@rmloveland rmloveland deleted the 20251110-DOC-8286-add-disk-slowness-log-message branch November 12, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants